Imported packages showing version of matching packages #1528
Conversation
nburnwal09
force-pushed
the
importPkgVersionMatch_fix
branch
from
00cdf58 to
6e0ab00
Compare
|
@nburnwal09 for example if you have two version of SLF4J API in your target platform you will get multiple providers for that bundle/package version. |
nburnwal09
force-pushed
the
importPkgVersionMatch_fix
branch
from
6e0ab00 to
0ab6d90
Compare
I have verified this. It's working. |
| @@ -61,16 +62,17 @@ public DependencyPropertiesDialog(boolean editable, ExportPackageObject object) | |||
|
|
|||
| public DependencyPropertiesDialog(boolean editable, boolean showReexport, boolean export, boolean optional, String version, boolean showOptional, boolean isImport, String pluginId) { | |||
| super(PDEPlugin.getActiveWorkbenchShell()); | |||
| isPlugin = showReexport; | |||
There was a problem hiding this comment.
If isPlugin equals fShowReexport it should not need a new field.
Beside this "fShowReexport" seem to indicate it is more about reexported packages?
There was a problem hiding this comment.
To find a unique value to identify for plug-in properties, I had assigned isPlugin with fShowReexport which is true only for plug-in case.
Now to avoid the confusion, I have updated and passed True value(which is false otherwise) in 'this' call only in case of required plug-in initialisation and using is as isPlugin.
laeubi
force-pushed
the
importPkgVersionMatch_fix
branch
from
0ab6d90 to
c8f78e6
Compare
nburnwal09
force-pushed
the
importPkgVersionMatch_fix
branch
from
9615226 to
0d5edfe
Compare
The commit fixes Properties dialog of Imported packages showing version of matching packages. Implemented similar to required plugin properties section
Fixes #1501
@laeubi
One questions here:-